Skip site navigation (1) Skip section navigation (2)

Re: Query tool column headers

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Query tool column headers
Date: 2012-06-29 09:20:21
Message-ID: CABUevEzzugy6BUSAyoN9twYdvFXX6HNNm2TDQ2v7fQ=Sxw8RBw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Wed, Jun 27, 2012 at 10:42 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Wed, 2012-06-27 at 17:24 +0100, Dave Page wrote:
>> On Wed, Jun 27, 2012 at 5:18 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> > On Wed, Jun 27, 2012 at 5:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >> On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> >>> Attached patch changes the column headers in the query tool to put <>
>> >>> aronud the datatype. While it's already on a separate line, this makes
>> >>> it more clear which part is the datatype and which part is the name of
>> >>> the column, making parsing easier on the eye when names and datatypes
>> >>> are close to each other.
>> >>>
>> >>> I looked for a way to make it italic or so instead, but it appears
>> >>> wxWidgets doesn't support that - it can only set the formatting for
>> >>> the whole header, which includes both the name and the datatype.
>> >>>
>> >>> Objections?
>> >>
>> >> Not sure I like it - it's better with ( ) instead of < >, but even so
>> >> it looks ugly with array types and size bounded types.
>> >
>> > Hmm. I didn't try with arrays...
>> >
>> >
>> >> Personally I don't think the ugliness is worth it, especially given
>> >> that (as you note) the type is on a separate line anyway.
>> >
>> > Got any ideas for another way to differentiate the datatype more from
>> > the column name, that might work?
>
> Nope, sorry. The best idea would be a different style (italic or
> something else), but I don't see how to do that with wxWidgets 2.8.
>
>>  (or correct my analysis and tell me
>> > that it *is* possible to make it italic or something like that)
>>
>> Nope. There's an outside chance you may be able to use an RTF string
>> there, but I seriously doubt it.
>>
>
> And so do I.

Yeah, seems not ot be there..

The other option would be to make it configurable (e.g.
pick-your-character-or-none-at-all), but that seems like more work
than it's worth...


>> BTW; *if* you find a way, then the same change should be made to the edit grid.
>>
>
> +1

Indeed.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2012-06-29 11:53:23
Subject: Re: [pgAdmin III] #365: pg_terminate_backend() can be used on backends with matching role on 9.2
Previous:From: Magnus HaganderDate: 2012-06-29 09:16:13
Subject: Re: Download section on website

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group