Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Date: 2011-07-12 13:34:56
Message-ID: CABUevEydhOM7p3Ja_Xgs2c2ob1hUPXc+9kPUwzNtodLu1Veq8g@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Jul 12, 2011 at 02:34, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Simon Riggs wrote:
>> On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote:
>> >> Robert Hass (whose name I misspelled in the commit message above) just
>> >> mentioned to me (in an answer to my apologizing about it) that he
>> >> didn't think that mentioning sponsors for patch development was a good
>> >> idea.
>> >>
>> >> I don't think we have a policy for this, but I have done it for some
>> >> time now and nobody has complained, so I sort of assumed it was okay.
>> >> Besides, some of the people pouring the money in does care about it;
>> >> moreover, it provides a little incentive for other companies that
>> >> might also be in a position to fund development but lack the "peer
>> >> approval" of the idea, or a final little push.
>> >
>> > I think commit messages should be restricted to describing what was
>> > changed and who is responsible for it. ?Once we open it for things like
>> > sponsorship, what's to stop people from adding personal messages, what
>> > they had for breakfast, "currently listening to", or just selling
>> > advertising space in each commit message for 99 cents?
>>
>> Agreed.
>>
>> We should credit people somewhere, but not here.
>>
>> Otherwise, we'll be forced to add "Sponsored by RedHat", "Sponsored by
>> 2ndQuadrant" etc onto commit messages.
>
> Agreed.  On one level I like the sponsor message, but on the other
> having "Sponsored by RedHat" on every Tom Lane item will get tiring.
> ;-)
>
> Can we add text if the employer is _not_ the feature sponsor?

That would be quite unfair to those who *do* employ committers....
Basically you'd get credit only if you didn't employ a committer.

This all becomes much easier if we keep the ads out of the commit
messages, and stick to the technical side there. And find another
venue for the other credit.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2011-07-12 13:54:34
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Previous:From: Florian PflugDate: 2011-07-12 13:03:10
Subject: Re: spinlock contention

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-07-12 13:54:34
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Previous:From: Robert HaasDate: 2011-07-12 12:26:59
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group