Re: Two strange settings in frmOptions

On Mon, Dec 12, 2011 at 15:08, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Mon, Dec 12, 2011 at 7:27 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Noticed two things in Options->QueryTool:
>>
>> 1) There is a settin gfor "Maximum rows to retreive". From what I can
>> tell, this is *only* used for pgagent (pgaJobs.cpp and pgaStep.cpp).
>> If that is so, it shuld not be under Query Tool settings. Potentially
>> it could be removed completely, if pgAgent can actually deal with a
>> hardcode there?
>
> It's not that pgAgent can or can't cope - it's just there to put a
> limit on the number of rows we try to load into the Statistics tab on
> the main form. Agreed, it shouldn't be under Query Tool.

I meant if we can get away with a hardcoded limit - e.g. make it
always do LIMIT 100.

>> 2) There is a setting for "Count rows if estimated less than". AFAICT,
>> this again has nothing to do with the query tool - this is for the
>> object browser, when you click a table. Shouldn't it be moved to be
>> under another tab?
>
> +1

Any suggestions for where?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/