Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Moving tablespaces

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-documentation <pgsql-docs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Moving tablespaces
Date: 2011-12-06 15:39:51
Message-ID: CABUevExQ=rFLxYXaivKR1ue_yv4BAuNy6z8fDn_3zqa3coZiFQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-docspgsql-hackers
On Tue, Dec 6, 2011 at 16:17, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Throwing an error seems a lot more safe in this case than just
>> returning NULL. Since it's a situtation that really shouldn't happen.
>> Maybe an assert, but I think a regular ereport(ERROR) would be the
>> best.
>
> Not an assert, since it's trivially user-triggerable.

Right.

There is some nice precedent in the CREATE TABLESPACE command (though
dependent on HAVE_SYMLINK and not HAVE_READLINK), so I'm just going to
copy the error message from there.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-docs by date

Next:From: Tom LaneDate: 2011-12-06 16:07:56
Subject: Re: [HACKERS] Moving tablespaces
Previous:From: Tom LaneDate: 2011-12-06 15:17:13
Subject: Re: [HACKERS] Moving tablespaces

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-12-06 15:53:58
Subject: Re: pull_up_simple_subquery
Previous:From: Tom LaneDate: 2011-12-06 15:17:13
Subject: Re: [HACKERS] Moving tablespaces

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group