On Wed, Jan 2, 2013 at 5:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Why are these very tar-specific functions being declared in such a
>>> globally visible spot as port.h? That seems like a bad idea on its
>>> face. IMO stuff in port.h ought to be about as globally applicable
>>> as, say, malloc().
>> It's where we put most of the things from src/port in.
> Might be time to revisit that, or perhaps better reconsider what we're
> putting in src/port/. The idea that anything that we want in both
> frontend and backend is a porting issue seems a bit busted in itself.
Yeah, true - but there's certainly other parts that think the same, so
that's a separate issue.
>> I take it you suggest moving it to a special say include/pgtar.h file?
> Works for me.
Applied. Should hopefully work once Alvaro gets the buildfarm back to green.
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2013-01-02 21:38:41|
|Subject: Re: Feature Request: pg_replication_master()|
|Previous:||From: Greg Stark||Date: 2013-01-02 18:04:39|
|Subject: Re: pg_basebackup from cascading standby after timeline switch|
pgsql-committers by date
|Next:||From: Alvaro Herrera||Date: 2013-01-02 21:00:17|
|Subject: pgsql: Set MaxBackends only on bootstrap and standalone modes|
|Previous:||From: Magnus Hagander||Date: 2013-01-02 19:37:43|
|Subject: pgsql: Move tar function headers to pgtar.h|