Skip site navigation (1) Skip section navigation (2)

Re: FATAL: bogus data in lock file "postmaster.pid": ""

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FATAL: bogus data in lock file "postmaster.pid": ""
Date: 2012-01-06 11:13:25
Message-ID: CABUevEwhH22SHK2aCJVWM75UG0QHLL9D+mGPaqt=XtGYDagVkw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Jan 5, 2012 at 23:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, Jan 5, 2012 at 17:13, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I think link(2) would create race conditions of its own.  I'd be
>>> inclined to suggest that maybe we should just special-case a zero length
>>> postmaster.pid file as meaning "okay to proceed".  In general, garbage
>
>> That's pretty much what I meant - but with a warning message.
>
> Actually ... wait a minute.  If we allow that, don't we create a race
> condition between two postmasters starting at almost the same instant?
> The second one could see the lock file when the first has created but
> not yet filled it.

Good point, yeah, it should do that. But I still think it's rare
enough that just special-casing the error message should be enough...

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2012-01-06 12:52:03
Subject: Unlogged tables and BufferSync()
Previous:From: Andres FreundDate: 2012-01-06 10:36:08
Subject: Re: 16-bit page checksums for 9.2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group