On Tue, Jan 17, 2012 at 23:07, Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> wrote:
>> I think the hook warrants a comment that, whether the messages will be
>> seen, depends on the log_min_messages setting.
> Comment added.
It seems you missed a comment, that the current implementation is also
affected by client_min_messages. I think that being affected by
client-specific settings is surprising. I would put the
if(emit_log_hook) inside the existing if(edata->output_to_server)
condition. Unless you have some reason to do it this way?
In response to
pgsql-hackers by date
|Next:||From: Daniel Farina||Date: 2012-01-17 21:43:11|
|Subject: Re: Should we add crc32 in libpgport?|
|Previous:||From: Martin Pihlak||Date: 2012-01-17 21:07:24|
|Subject: Re: Patch review for logging hooks (CF 2012-01)|