Skip site navigation (1) Skip section navigation (2)

Re: Patch review for logging hooks (CF 2012-01)

From: Marti Raudsepp <marti(at)juffo(dot)org>
To: Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch review for logging hooks (CF 2012-01)
Date: 2012-01-17 21:40:04
Message-ID: CABRT9RAUMWifGz7CCDokZSMd+8RwbLjguyOekGWTOrG-We6Tgg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi!

On Tue, Jan 17, 2012 at 23:07, Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> wrote:
>> I think the hook warrants a comment that, whether the messages will be
>> seen, depends on the log_min_messages setting.
>
> Comment added.

Nice :)

It seems you missed a comment, that the current implementation is also
affected by client_min_messages. I think that being affected by
client-specific settings is surprising. I would put the
if(emit_log_hook) inside the existing if(edata->output_to_server)
condition. Unless you have some reason to do it this way?

Regards,
Marti

In response to

Responses

pgsql-hackers by date

Next:From: Daniel FarinaDate: 2012-01-17 21:43:11
Subject: Re: Should we add crc32 in libpgport?
Previous:From: Martin PihlakDate: 2012-01-17 21:07:24
Subject: Re: Patch review for logging hooks (CF 2012-01)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group