On Thu, Sep 29, 2011 at 10:52 AM, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> wrote:
> On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> writes:
>> > I noticed that the savepointLevel member of TransactionStateData struct
>> > is
>> > initialized to 0 from TopTransactionStateData, and never incremented or
>> > decremented afterwards.
>> > Since this is a file-local struct I think we can simply get rid of all
>> > usages of this without any risk.
>> ISTM you have detected a bug, not just dead code that should be removed.
>> Surely those tests that throw error on savepointLevel change were
>> meant to do something important?
> That's surprising for dead-code removal!
> Not sure which failures you're pointing to. `make check` before and after
> the patch on master says 'All 126 tests passed.'
I think Tom is talking about the test in the code and not a regression
test itself. Looking at the archives and git log, it seems though that
we never completed this feature and the code was always dead since its
In response to
pgsql-hackers by date
|Next:||From: Kyotaro HORIGUCHI||Date: 2011-09-29 08:20:33|
|Subject: Re: [REVIEW] pg_last_xact_insert_timestamp|
|Previous:||From: Gurjeet Singh||Date: 2011-09-29 05:22:46|
|Subject: Re: Removing savepointLevel from TransactionState|