| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Simplifying the interface of UpdateMinRecoveryPoint |
| Date: | 2016-07-13 03:49:46 |
| Message-ID: | CAB7nPqQjgNLZTH5KTp32QK19k7LyiW6OUZBDBSoJios=nxPk_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
As of now UpdateMinRecoveryPoint() is using two arguments:
- lsn, to check if the minimum recovery point should be updated to that
- force, a boolean flag to decide if the update should be enforced or not.
However those two arguments are correlated. If lsn is
InvalidXlogRecPtr, the minimum recovery point update will be enforced.
Hence why not simplifying its interface and remove the force flag? See
attached.
Thanks,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| xlog-simplify-min-reco.patch | text/x-patch | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-07-13 06:50:03 | Re: dumping database privileges broken in 9.6 |
| Previous Message | Michael Paquier | 2016-07-13 03:29:49 | RecoveryTargetTLI dead variable in XLogCtlData |