| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200) |
| Date: | 2016-08-22 01:43:19 |
| Message-ID: | CAB7nPqQKZbW9PL+viSmO76N8yqs1JPVAT7=uOMNKNOC8+XoM8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 6, 2016 at 6:35 PM, Andreas Seltenreich <seltenreich(at)gmx(dot)de> wrote:
> Michael Paquier writes:
>
>> Andreas, with the patch attached is the assertion still triggered?
>> [2. text/x-diff; base-backup-crash-v2.patch]
>
> I didn't observe the crashes since applying this patch. There should
> have been about five by the amount of fuzzing done.
I have reworked the patch, replacing those two booleans with a single
enum. That's definitely clearer. Also, I have added this patch to the
CF to not lose track of it:
https://commitfest.postgresql.org/10/731/
Horiguchi-san, I have added you as a reviewer as you provided some
input. I hope you don't mind.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| base-backup-crash-v3.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-08-22 01:44:18 | Re: dsm_unpin_segment |
| Previous Message | Haribabu Kommi | 2016-08-22 01:05:44 | Re: New SQL counter statistics view (pg_stat_sql) |