Skip site navigation (1) Skip section navigation (2)

Postgres ReviewFest Patch: URI connection string support for libpq

From: Nick Roosevelt <nroose(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Postgres ReviewFest Patch: URI connection string support for libpq
Date: 2012-01-13 04:07:04
Message-ID: CAAyg8k0KxT6xa2ADcZwJzBTdR-BeE1tN_UKbt24HvCaL3VvGig@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Just reviewed the patch for adding URI connection string support for libpg.

There seem to be many tabs in the patch.  Perhaps the indentation is not
correct.

Also, the patch did not run correctly:

patching file src/interfaces/libpq/fe-connect.c
Hunk #1 succeeded at 282 with fuzz 1.
Hunk #2 FAILED at 300.
Hunk #3 FAILED at 583.
Hunk #4 FAILED at 3742.
Hunk #5 FAILED at 4132.
Hunk #6 FAILED at 4279.
Hunk #7 FAILED at 4455.
6 out of 7 hunks FAILED -- saving rejects to file
src/interfaces/libpq/fe-connect.c.rej

Seems like the file has changed since this patch was created.  Please
recreate the patch.

Thanks,

Nick Roosevelt

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2012-01-13 04:18:40
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Previous:From: Fujii MasaoDate: 2012-01-13 03:58:32
Subject: Re: log messages for archive recovery progress

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group