| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Replication identifiers, take 4 |
| Date: | 2015-04-29 20:12:14 |
| Message-ID: | CAApHDvqeJWJtY-=AP6biHn=RHmEUeFVQy6uCGV8yZTMokht84g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25 April 2015 at 00:32, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Attached is a patch that does this, and some more, renaming. That was
> more work than I'd imagined. I've also made the internal naming in
> origin.c more consistent/simpler and did a bunch of other cleanup.
>
>
Hi,
It looks like bowerbird is not too happy with this, neither is my build
environment.
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-29%2019%3A31%3A06
The attached seems to fix it.
I put the include in the origin.h rather than in the origin.c as the
DoNotReplicateId macro uses UINT16_MAX and is also used in xact.c.
Regards
David Rowley
| Attachment | Content-Type | Size |
|---|---|---|
| UINT16_MAX_fix.patch | application/octet-stream | 382 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2015-04-29 20:14:36 | Re: Replication identifiers, take 4 |
| Previous Message | Robert Haas | 2015-04-29 20:12:05 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |