Re: Inconsistency in libpq connection parameters, and extension thereof

From: Daniel Farina <daniel(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Shulgin <ash(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistency in libpq connection parameters, and extension thereof
Date: 2012-06-06 22:04:48
Message-ID: CAAZKuFZ=euo54yNHO=URmKM83VMxhGqnoHZm=Aem7JSt_F_L7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 6, 2012 at 1:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Jun 6, 2012 at 4:08 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> However, not throwing errors on the URL syntax should be considered a
>> bug, I think.
>
> +1.

+1

Here's a patch that just makes the thing an error. Of course we could
revert it if it makes the URI feature otherwise unusable...but I don't
see a huge and terrible blocker ATM. A major question mark for me any
extra stuff in JDBC URLs.

Nevertheless, here it is.

--
fdr

Attachment Content-Type Size
libpq-error-on-unknown-parameters-in-URIs-v1.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2012-06-06 22:24:08 Re: How could we make it simple to access the log as a table?
Previous Message Tom Lane 2012-06-06 21:21:35 Re: creating objects in pg_catalog