Skip site navigation (1) Skip section navigation (2)

Re: FDW system columns

From: Thom Brown <thom(at)linux(dot)com>
To: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FDW system columns
Date: 2012-02-25 20:56:13
Message-ID: CAA-aLv7caZehrBBOwEFSoKEFZJZEW1B7C5ggQc7_BFt_PpBOrg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 14 November 2011 13:07, Thom Brown <thom(at)linux(dot)com> wrote:
> 2011/11/14 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
>>
>> (2011/11/14 11:25), Robert Haas wrote:
>> > My vote is to nuke 'em all.  :-)
>>
>> +1.
>>
>> IIRC, main purpose of supporting tableoid for foreign tables was to be
>> basis of foreign table inheritance, which was not included in 9.1, and
>> we have not supported it yet.  Other system columns are essentially
>> garbage, but they survived at 9.1 development because (maybe) it seemed
>> little odd to have system columns partially at that time.
>>
>> So, IMHO removing all system columns from foreign tables seems
>> reasonable, unless it doesn't break any external tool seriously (Perhaps
>> there would be few tools which assume that foreign tables have system
>> columns).
>>
>> If there seems to be a consensus on removing system column from foreign
>> tables, I'd like to work on this issue.  Attached is a halfway patch,
>> and ISTM there is no problem so far.
>
>
> I can say that at least PgAdmin doesn't use these columns.

So we still have all of these columns for foreign tables.  I've tested
Hanada-san's patch and it removes all of the system columns.  Could we
consider applying it, or has a use-case for them since been
discovered?

-- 
Thom

In response to

Responses

pgsql-hackers by date

Next:From: Jeff JanesDate: 2012-02-25 21:31:06
Subject: Re: Memory usage during sorting
Previous:From: Jeff JanesDate: 2012-02-25 20:46:54
Subject: Re: Scaling XLog insertion (was Re: Moving more work outside WALInsertLock)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group