Skip site navigation (1) Skip section navigation (2)

Re: Altering column collation

From: Thom Brown <thom(at)linux(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Altering column collation
Date: 2011-07-19 19:43:17
Message-ID: CAA-aLv6bW=EgFz1t3uo2F6rc_Vua_pasd9nigE35yK8trkNSzA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 19 July 2011 08:32, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote:
>> [...]
>> Attached is a patch which fixes #328.  Currently if you change a
>> column's collation, it actually drops the column.  This changes it so
>> that it issues an ALTER TYPE to adjust the collation instead.
>>
>
> Pushed on master. Thanks for yet another patch :)
>
> I didn't push it on 1.14 yet. The patch doesn't work here, and I guess
> it's because I didn't push your previous patch. I'm not sure on the best
> move here. Should we simply remove the bug (no change detected when
> changing collation on the column properties dialog)? or should we apply
> both patches (which will give us bugfix, and better handling of
> columns)? Any ideas?

Why can't we apply the patch to 1.14?  I don't recall making any
previous changes to dlgColumn.cpp.  I just switched to 1.14,
fast-forwarded all updates, applied the patch, built it, and it
behaves correctly.

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-07-19 20:04:49
Subject: Re: Altering column collation
Previous:From: Guillaume LelargeDate: 2011-07-19 19:27:48
Subject: Re: Altering column collation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group