Re: Prevent duplicate attributes

On 14 July 2011 10:24, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> On Tue, 2011-07-12 at 11:17 +0100, Thom Brown wrote:
>> On 12 July 2011 11:11, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> > On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote:
>> >> On 12 July 2011 10:53, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >> > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>> >> >> Hi (yes, me... again),
>> >> >>
>> >> >> Tiny patch attached to prevent adding attributes with a duplicate name
>> >> >> to a type.  It seems previous versions prevented this, but must have
>> >> >> been allowed in a commit since the last release.
>> >> >
>> >> > For consistency with the other checks on the dialogue, this should
>> >> > cause the "Add" button to be disabled, not make it silently fail. That
>> >> > should almost certainly be done in dlgType::CheckChange().
>> >>
>> >> Yes, you're right.
>> >>
>> >
>> > Does this patch need to be applied after the "overhaul of type
>> > attributes" one?
>>
>> No, as this patch shouldn't be applied at all since, as Dave pointed
>> out, the duplicate check should appear in CheckChange().  This is an
>> existing bug unrelated to the type attribute changes patch.  I just
>> noticed it while testing my changes.
>>
>
> So, you're working on fixing it, right?

Possibly ;) : http://code.pgadmin.org/trac/ticket/329

I haven't had time to look at fixing various bugs over the last couple
days but I'll get to them shortly.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company