Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Date: 2012-01-12 08:53:28
Message-ID: CA+U5nMLN0MG=h9cJRyVb35gB4crKVhpdkvaPTvUHCKgcKuQ9BQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Thu, Jan 12, 2012 at 3:09 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Jan 12, 2012 at 12:20 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> +static void
>>> +ProcessWalSndrMessage(XLogRecPtr walEnd, TimestampTz sendTime)
>>>
>>> walEnd is not used in ProcessWalSndrMessage() at all. Can't we remove it?
>>> If yes, walEnd field in WalSndrMessage is also not used anywhere, so ISTM
>>> we can remove it.
>>
>> It's there to allow extension of the message processing to be more
>> complex than it currently is. Changing the protocol is much harder
>> than changing a function call.
>>
>> I'd like to keep it since it doesn't have any negative effects.
>
> OK. Another problem about walEnd is that WalDataMessageHeader.walEnd is not
> the same kind of location as WalSndrMessage.walEnd. The former indicates the
> location that WAL has already been flushed (maybe not sent yet), i.e.,
> "send request
> location". OTOH, the latter indicates the location that WAL has
> already been sent.
> Is this inconsistency intentional?

WalSndrMessage isn't set to anything, its just a definition.

PrimaryKeepaliveMessage is a message type that uses WalSndrMessage.
That message type is only sent when the WalSndr is quiet, so what is
the difference, in that case?

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2012-01-12 09:00:25
Subject: Re: measuring spinning
Previous:From: Ashutosh BapatDate: 2012-01-12 04:28:55
Subject: Re: Confusing EXPLAIN output in case of inherited tables

pgsql-committers by date

Next:From: Fujii MasaoDate: 2012-01-12 10:37:23
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Previous:From: Fujii MasaoDate: 2012-01-12 03:09:15
Subject: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group