Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Resolve timing issue with logging locks for Hot Standby.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Resolve timing issue with logging locks for Hot Standby.
Date: 2012-01-31 08:59:12
Message-ID: CA+U5nML0=OYeUp+T964f=-ZKpg++Sgr=8_CX=g+eR5eMK2e2Sw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committers
On Mon, Jan 30, 2012 at 4:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 01/30/2012 10:45 AM, Tom Lane wrote:
>>> Another aspect of this is that when the same-or-almost-the-same patch
>>> is applied to multiple branches, it's a *lot* easier for future
>>> archeology in the commit logs if the patch goes into all the affected
>>> branches at the same time (and with the same commit message, please).
>
>> Yeah, I've been pinged on this before, for exactly this reason. It makes
>> release note preparation significantly easier, AIUI.
>
> Not just release notes, but routine questions like "when was this bug
> fixed, and in which branches?".  I keep a regularly-updated copy of
> the output of src/tools/git_changelog (before git we used cvs2cl
> to get similar output from CVS).  It's a rare day that I don't have
> some occasion to consult it.  I don't appreciate committers randomly
> cluttering that log by making commits that the tool doesn't know how
> to merge.

As you request it, I will endeavour to do this next time.

I think its more likely errors will occur that way, however.
Responsibility for any such errors is still mine so there may be times
where that outweighs other thoughts, but as policy I'm happy to make
apply-all-at-once the default.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

pgsql-committers by date

Next:From: Robert HaasDate: 2012-01-31 16:50:58
Subject: pgsql: Built-in JSON data type.
Previous:From: Heikki LinnakangasDate: 2012-01-31 08:41:20
Subject: pgsql: Print function signature, not just name,in PL/pgSQL error messa

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group