On Mon, Nov 21, 2011 at 10:03 PM, Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I just noticed that btvacuumpage has two BlockNumber parameters -- blkno
> and orig_blkno. The only caller passes them as the same value; the
> header comments state that blkno would be different when recursing, but
> actually the function implements recursion internally by way of a cute
> "goto" trick. So it seems to me that the orig_blkno parameter is
> useless -- we could just remove it.
>
> Unless I'm completely missing something?
tail recursion - read comments at bottom of the function
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
In response to
Responses
pgsql-hackers by date
| Next: | From: Alvaro Herrera | Date: 2011-11-21 22:19:13 |
| Subject: Re: btvacuumpage useless "orig_blkno" |
| Previous: | From: Alvaro Herrera | Date: 2011-11-21 22:03:59 |
| Subject: btvacuumpage useless "orig_blkno" |