Re: Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover

On 2 October 2012 19:06, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Sat, Aug 11, 2012 at 2:19 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Thu, Aug 9, 2012 at 8:08 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> On 29 July 2012 16:01, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>
>>>> Attached patch changes the startup process so that it creates .done file
>>>> whenever WAL file is successfully restored, whether archive mode is
>>>> enabled or not. The restored WAL files will not be archived again because
>>>> of .done file.
>>>
>>> The proposed patch works, for archiving only, but I don't like the
>>> code. It's a partial refactoring of existing code.
>>>
>>> I prefer to go for a full re-factoring version for HEAD, and a zero
>>> refactoring version for 9.2 since we're deep into beta.
>
> Isn't it time to push the full re-factoring version to HEAD? If there is no
> such version yet, what about pushing the zero refactoring version for now?

If you send a rebased patch, I'll review, but its not high on my radar
right now unless you can explain why it should be higher.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services