From:
Simon Riggs <simon(at)2ndquadrant(dot)com>
To:
Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc:
Steve Singer <ssinger_pg(at)sympatico(dot)ca>,
Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>, magnus(at)hagander(dot)net,
heikki(dot)linnakangas(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org,
robertmhaas(at)gmail(dot)com, cedric(dot)villemain(dot)debian(at)gmail(dot)com
Subject:
Re: Online base backup from the hot-standby
Date:
2012-01-20 11:15:55
Message-ID:
CA+U5nMJFBKTJttaL6r-aHZPfWSBA+Byhz7FK+EF8R86TzPPHnQ@mail.gmail.com (view raw or flat )
Thread:
2011-08-05 06:45:47 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-08-05 08:02:15 from Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
2011-08-15 08:46:53 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-08-15 11:52:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-08-16 06:09:16 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-08-16 15:24:24 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2011-08-17 08:59:37 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-08-17 10:19:03 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-08-17 12:40:15 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-08-17 13:53:08 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-08-17 15:09:43 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-08-18 01:43:21 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-08-16 06:12:59 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-08-18 02:12:55 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-08-18 05:47:25 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-09-12 06:46:37 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-09-13 06:50:28 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-09-21 02:50:24 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-21 05:13:21 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-09-21 06:23:53 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-21 08:34:26 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-09-22 12:13:43 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-22 15:44:44 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-09-26 12:12:41 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-21 16:52:18 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-09-26 08:07:21 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-22 13:24:51 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-26 02:39:00 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2011-09-27 02:56:25 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-27 05:51:38 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-09 18:04:25 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-09 18:56:11 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2011-10-11 10:15:54 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-11 15:17:27 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-11 21:44:34 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2011-10-12 02:43:59 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-12 07:27:02 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-12 07:53:52 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-13 04:31:27 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-13 05:01:38 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-13 09:39:09 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-14 12:28:29 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-15 01:35:45 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-15 02:12:36 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-17 07:16:05 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-18 06:25:46 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-19 02:47:08 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-19 07:37:32 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-10-24 12:29:20 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-24 15:24:28 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-10-25 05:12:20 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-25 06:44:30 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-10-25 08:50:10 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-25 10:19:33 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-10-25 11:54:58 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-25 12:03:57 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-10-26 01:48:05 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-31 04:11:19 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
2011-11-15 02:11:38 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2012-01-13 08:02:55 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-17 10:38:23 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-20 04:01:49 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2012-01-20 09:48:59 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-20 10:37:41 from "Erik Rijkers" <er(at)xs4all(dot)nl>
2012-01-20 11:04:29 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-20 11:26:35 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-20 11:15:55 from Simon Riggs <simon(at)2ndquadrant(dot)com>
2012-01-20 12:54:28 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-20 14:34:31 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-23 10:29:20 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-23 13:11:04 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-24 09:51:13 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-24 10:54:56 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-24 11:22:16 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-25 08:16:40 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-25 08:49:42 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-25 18:07:24 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-01-26 06:09:33 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-01-23 13:11:10 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-01-23 13:13:51 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-11-03 23:06:16 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-11-04 04:20:31 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-25 12:56:47 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2011-10-25 13:05:11 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-10-24 15:33:40 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-10-24 15:38:18 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-10-25 05:37:48 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-10-13 13:44:50 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-27 23:10:39 from Steve Singer <ssinger_pg(at)sympatico(dot)ca>
2011-09-28 01:58:19 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2011-09-26 08:41:06 from Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp>
Lists:
pgsql-hackers
On Tue, Jan 17, 2012 at 10:38 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Jan 13, 2012 at 5:02 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> The amount of code changes to allow pg_basebackup to make a backup from
>> the standby seems to be small. So I ended up merging that changes and the
>> infrastructure patch. WIP patch attached. But I'd happy to split the patch again
>> if you want.
>
> Attached is the updated version of the patch. I wrote the limitations of
> standby-only backup in the document and changed the error messages.
I'm looking at this patch and wondering why we're doing so many
press-ups to ensure full_page_writes parameter is on. This will still
fail if you use a utility that removes the full page writes, but fail
silently.
I think it would be beneficial to explicitly check that all WAL
records have full page writes actually attached to them until we
achieve consistency.
Surprised to see XLOG_FPW_CHANGE is there again after I objected to it
and it was removed. Not sure why? We already track other parameters
when they change, so I don't want to introduce a whole new WAL record
for each new parameter whose change needs tracking.
Please make a note for committer that wal version needs bumping.
I think its probably time to start a README.recovery to explain why
this works the way it does. Other changes can then start to do that as
well, so we can keep this to sane levels of complexity.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
In response to
Responses
pgsql-hackers by date
Next :From: Magnus HaganderDate: 2012-01-20 11:24:29
Subject : Re: IDLE in transaction introspection
Previous :From : Fujii MasaoDate : 2012-01-20 11:04:29
Subject : Re: Online base backup from the hot-standby