Skip site navigation (1) Skip section navigation (2)

Further plans to refactor xlog.c

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Further plans to refactor xlog.c
Date: 2011-11-03 18:14:39
Message-ID: CA+U5nM+BEH4J3=SWZnaCxeX1ToN5MWAG49z7Z9Yfzie=GgDkaQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Next steps in refactoring are bigger steps, but not huge ones.

I propose this

* everything to do with XLOG rmgr into a file called xlogrmgr.c
Thats xlog_redo() and most everything to do with checkpoints

* everything to do with reading WAL files into a file called xlogread.c
That will allow us to put pg_xlogdump into core

* possibly some more stuff into xlogboot.c

The above actions will reduce xlog.c to about 7000 lines, about 4000
lines smaller than when I started. That sounds like it could go
further, but it moves out most of the areas of recent growth by
focusing on the purpose of that code.

An obvious split would seem to be move all recovery-side code into its
own file. That seems quite likely to take a lot of time, break
something, as well as requiring us to share XLogCtl, all of which
personally I would rather avoid.

Fujii's work is likely to remove another few hundred lines as well.

That seems enough to me.... OK?

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Responses

pgsql-hackers by date

Next:From: Florian PflugDate: 2011-11-03 18:19:14
Subject: Re: Term positions in GIN fulltext index
Previous:From: Pavan DeolaseeDate: 2011-11-03 18:12:52
Subject: Storing hot members of PGPROC out of the band

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group