Skip site navigation (1) Skip section navigation (2)

Re: [RFC] Common object property boards

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kohei Kaigai <kohei(dot)kaigai(at)emea(dot)nec(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Common object property boards
Date: 2011-08-01 20:12:56
Message-ID: CA+Tgmobwq=M6g3BKRcCQqAiCPW5o23eKqDrttORdGihDHTH0+A@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Aug 1, 2011 at 4:02 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Excerpts from Kohei KaiGai's message of dom jul 31 02:21:55 -0400 2011:
>> 2011/7/29 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>
>> > It would likely be better to not expose the struct type, just individual
>> > lookup functions.
>> >
>> If so, individual functions to expose a certain property of the supplied
>> object type should be provided.
>>
>>   int get_object_property_catid_oidlookup(ObjectType);
>>   int get_object_property_catid_namelookup(ObjectType);
>>   Oid get_object_property_relation_id(ObjectType);
>>   AttrNumber get_object_property_nameattnum(ObjectType);
>>   AttrNumber get_object_property_namespacenum(ObjectType);
>>   AttrNumber get_object_property_ownershipnum(ObjectType);
>
> Maybe a single lookup function that receives pointers that the lookup
> routine can fill with the appropriate information; allowing for a NULL
> pointer in each, meaning caller is not interested in that property.

That seems like a lot of extra notational complexity for no particular
benefit.  Every time someone wants to add a new property to this
array, they're going to have to touch every caller, and all
third-party code using this interface will have to be rejiggered.  I
still think that just returning a pointer to the struct is a perfectly
sensible API...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: David FetterDate: 2011-08-01 20:23:57
Subject: Re: libedit memory stomp is apparently fixed in OS X Lion
Previous:From: Simon RiggsDate: 2011-08-01 20:02:45
Subject: Re: Compressing the AFTER TRIGGER queue

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group