Skip site navigation (1) Skip section navigation (2)

Re: [v9.3] OAT_POST_ALTER object access hooks

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [v9.3] OAT_POST_ALTER object access hooks
Date: 2013-03-27 12:34:38
Message-ID: CA+Tgmobd_-WD2tMKwy3zcM0iNWx-TnxsXPLHEqLvk7mYnF-mGA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Mar 19, 2013 at 9:28 AM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>>  But I've left it the way you have it for now.  Part
>> of me thinks that what you really want here is a pre-alter hook rather
>> than a post-alter hook...
>>
> Yes. It is the reason why I wanted to put a pre-alter hook for this
> code path exceptionally.
>
> The attached patch is rebased version of contrib/sepgsql patch.
> Even though I added nothing from the previous one, it might make
> sense to add checks for the cases when user altered external
> properties of tables (such as triggers, attribute-default, ...).
> How about your opinion? It is middle of March now.

It might make sense to rework this further in a future release, but I
don't think we can do that now.

Anyhow, I've committed the rest of this patch.  Sorry that took so long.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2013-03-27 12:41:18
Subject: Re: [sepgsql 1/3] add name qualified creation label
Previous:From: Robert HaasDate: 2013-03-27 12:33:16
Subject: pgsql: sepgsql: Support for new post-ALTER access hook.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group