| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masao Fujii <masao(dot)fujii(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Waits monitoring |
| Date: | 2015-09-11 18:03:26 |
| Message-ID: | CA+TgmobOXu=KZqyOKU8NBS6YsiJH0KPytoN+KhF+xxFCPT4bxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 10, 2015 at 3:43 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Generated lwlocknames.[ch] don't have header comment because
> generate-lwlocknames.pl writes them into wrong place.
>
> lmgr/Makefile looks to have some mistakes.
Fixed.
> - lwlocknames.c is not generated from (or using) lwlocknames.c
> so the entry "lwlocknames.c: lwlocknames.h" doesn't looks to
> be appropriate.
I think that's a pretty standard way of handling a case where a single
command generates multiple files.
> - maintainer-clean in lmgr/Makefile forgets to remove lwlocknames.c.
Fixed.
> Perhaps uncommenting in pg_config_manual.h is left alone.
> (This is not included in the diff below)
Fixed.
And committed. Thanks for the review, let's see what the buildfarm thinks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2015-09-11 18:23:48 | pgsql: Fix an O(N^2) problem in foreign key references. |
| Previous Message | Tomas Vondra | 2015-09-11 17:56:44 | Re: DBT-3 with SF=20 got failed |