From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Thomas Ogrisegg <tom-nic(at)patches(dot)fnord(dot)at> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: PATCH: pg_basebackup (missing exit on error) |
Date: | 2012-01-26 14:48:08 |
Message-ID: | CA+TgmoaycwtMwyRSMUHm=_LzELDVV2z-as910fRufj9fbvicZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 24, 2012 at 4:39 AM, Thomas Ogrisegg
<tom-nic(at)patches(dot)fnord(dot)at> wrote:
> While testing a backup script, I noticed that pg_basebackup exits with
> 0, even if it had errors while writing the backup to disk when the
> backup file is to be sent to stdout. The attached patch should fix this
> problem (and some special cases when the last write fails).
This part looks like a typo:
+ if (fflush (tarfile) != 0)
+ {
+ fprintf(stderr, _("%s:
error flushing stdout: %s\n"),
+
strerror (errno));
+ disconnect_and_exit(1);
+ }
The error is in flushing the tarfile, not stdout, right?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Kupershmidt | 2012-01-26 14:52:49 | Re: Psql names completion. |
Previous Message | Robert Haas | 2012-01-26 14:40:06 | Re: [v9.2] sepgsql's DROP Permission checks |