Skip site navigation (1) Skip section navigation (2)

Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Vik Reykja <vikreykja(at)gmail(dot)com>
Cc: Giuseppe Sucameli <brush(dot)tyler(at)gmail(dot)com>, Marc Balmer <marc(at)msys(dot)ch>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"
Date: 2012-01-26 15:19:31
Message-ID: CA+TgmoagVmqkwcZc-Wb3M=o0OTRXORecs7S9oA-SA500ya0hsw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On Thu, Jan 26, 2012 at 5:43 AM, Vik Reykja <vikreykja(at)gmail(dot)com> wrote:
> On Wed, Jan 25, 2012 at 22:19, Giuseppe Sucameli <brush(dot)tyler(at)gmail(dot)com>
> wrote:
>>
>> thinking you have no skills, I wrote a patch too and posted it to
>> hackers ML about 2 days ago, but I didn't subscribe that list so
>> it is stalled, waiting for someone's approval.
>>
>> For this reason my email is not displayed in the archives.
>> I'm so sorry both have wasted our time in writing 2 patches for
>> the same bug.
>
> I think your patch is more complete than mine so it's definitely not
> wasted.  I spent several hours on mine and now I have a little bit of skills
> :-)
>
> Thank you for your effort; I'm sorry if you feel you have wasted your time.

I think Vik's patch is better, because it doesn't rely as much on
things that happen to be true today - like which relkinds have system
columns associated with them.  But I do agree we ought to handle both
the ADD COLUMN and RENAME COLUMN cases, and as such have posted an
update of Vik's patch on the other thread.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan

In response to

pgsql-hackers by date

Next:From: Abhijit Menon-SenDate: 2012-01-26 15:28:12
Subject: Re: proposal: better support for debugging of overloaded functions
Previous:From: Robert HaasDate: 2012-01-26 15:16:18
Subject: Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"

pgsql-bugs by date

Next:From: Eric BortsDate: 2012-01-26 18:37:43
Subject: Re: Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)
Previous:From: Euler Taveira de OliveiraDate: 2012-01-26 14:51:16
Subject: Re: One question about VACUUMDB command - please

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group