Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing
Date: 2012-03-28 12:19:37
Message-ID: CA+TgmoaZcHwE-LctPZx5P1qOeiH3M=YM-Z9WtZiXErm8zTSXCg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Mar 27, 2012 at 10:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Mar 28, 2012 at 5:17 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> pg_test_timing utility, to measure clock monotonicity and timing cost.
>
> When I compiled this, I got a compiler warning. Attached patch
> silences the warning.

Unfortunately, that *produces* a warning on my machine.  Normally, I
think we handle this using INT64_FORMAT, but the fact that it's %10ld
here and not just %lld makes that awkward.  I guess we maybe need to
insert some kludgy workaround here - write it into a separate buffer,
and then blank-pad it, or something like that.

> Also I found one trivial problem in the doc of pg_test_timing. The
> patch fixes that.

Thanks, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Shigeru HANADADate: 2012-03-28 12:25:45
Subject: Re: pgsql_fdw, FDW for PostgreSQL server
Previous:From: Robert HaasDate: 2012-03-28 12:10:04
Subject: Re: Command Triggers patch v18

pgsql-committers by date

Next:From: Robert HaasDate: 2012-03-28 12:43:56
Subject: pgsql: pg_basebackup: Error message improvements.
Previous:From: Fujii MasaoDate: 2012-03-28 02:10:46
Subject: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group