On Mon, Dec 31, 2012 at 11:51 AM, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
> I thought I followed the conding style - which guidelines have I broken?
+ /* If there are no non-local relations, then we're done. Release the memory
+ * and return. */
Multi-line comments should start with a line containing only /* and
end with a line containing only */.
+DropRelFileNodeAllBuffers(RelFileNodeBackend * rnodes, int nnodes)
+rnode_comparator(const void * p1, const void * p2)
The extra spaces after the asterisks should be removed.
+void smgrdounlinkall(SMgrRelation * rels, int nrels, bool isRedo)
void should be on a line by itself.
Sorry to nitpick.
As for BSEARCH_LIMIT, I don't have a great idea - maybe just
The Enterprise PostgreSQL Company
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2013-01-04 16:54:42|
|Subject: Re: lock AccessShareLock on object 0/1260/0 is already held|
|Previous:||From: 孟庆钟||Date: 2013-01-04 16:13:27|
|Subject: A very small typo in the comment |