| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dan Scales <scales(at)vmware(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, david(at)fetter(dot)org, aidan(at)highrise(dot)ca, stark(at)mit(dot)edu, pgsql-hackers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: 16-bit page checksums for 9.2 |
| Date: | 2012-01-30 15:26:05 |
| Message-ID: | CA+TgmoaLcWCZ2UtO9bt2A0atwxCOQAm6XNhugpwyPLVX4pWzug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 27, 2012 at 4:07 PM, Dan Scales <scales(at)vmware(dot)com> wrote:
> The advantage of putting the checksum calculation in smgrwrite() (or mdwrite()) is that it catches a bunch of page writes that don't go through the buffer pool (see calls to smgrwrite() in nbtree.c, nbtsort.c, spginsert.c)
Maybe we should have some sort of wrapper function, then. I really
dislike the idea that the smgr layer knows anything about the page
format, and if md has to know that's even worse.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-01-30 15:32:01 | Re: Group commit, revised |
| Previous Message | Robert Haas | 2012-01-30 15:24:21 | Re: Simulating Clog Contention |