Skip site navigation (1) Skip section navigation (2)

Re: Torn page hazard in ginRedoUpdateMetapage()

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Farina <daniel(at)heroku(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Torn page hazard in ginRedoUpdateMetapage()
Date: 2012-05-03 12:54:44
Message-ID: CA+Tgmoa+mACK8j2TbqgjTYvgz1tPJa0uFxu4upTARw_xnkQw_Q@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, May 3, 2012 at 12:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Having said all that, I wasn't really arguing that this was a guaranteed
> safe thing for us to rely on; just pointing out that it's quite likely
> that the issue hasn't been seen in the field because of this type of
> consideration.

Well, we do rely, in numerous places, on writes << 512 bytes not
getting torn.  pd_prune_xid, index tuple kills, heap tuple hint bits,
relmapper files, etc.  We generally assume, for example, that a 4-byte
write which is 4-byte aligned does not need to be WAL-logged, which
would be necessary if we thought that the write might be torn.

Are you planning to commit Noah's patch?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2012-05-03 13:01:25
Subject: Re: ALTER DATABASE and datallowconn
Previous:From: Simon RiggsDate: 2012-05-03 12:48:43
Subject: Re: ALTER DATABASE and datallowconn

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group