Re: Command Triggers, patch v11

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thom Brown <thom(at)linux(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Command Triggers, patch v11
Date: 2012-03-09 15:29:31
Message-ID: CA+TgmoZydQgvUFOaf9yh1JrvAUOvj0tWoGQi3-pW9xb_3sRYQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 9, 2012 at 10:05 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Mar 9, 2012 at 9:22 AM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> Sorry, I meant any command trigger.  It's because none of the commands
>>> can be run on a standby, so the triggers don't seem appropriate.
>
>> I'm not convinced.  Right now, it's fairly useless - all the triggers
>> could possibly do is throw an error, and an error is going to get
>> thrown anyway, so it's only a question of which error message the user
>> will see.  But we discussed before the idea of adding a capability for
>> BEFORE triggers to request that the actual execution of the command
>> get skipped, and then it's possible to imagine this being useful.
>
> Um, surely the "you can't do that in a read-only session" error is going
> to get thrown long before the command trigger could be called?

Hmmm.... yeah.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-03-09 15:31:26 Re: xlog location arithmetic
Previous Message Bruce Momjian 2012-03-09 15:26:47 Re: pg_upgrade and umask