| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Greg Smith <greg(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch review for logging hooks (CF 2012-01) |
| Date: | 2012-01-20 15:01:47 |
| Message-ID: | CA+TgmoZw6y3zYZ5ude3=qd6CebAXvZzTKf8fJumhcbXj8wjmgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 20, 2012 at 2:47 AM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>> The updated patch looks good, marking as 'Ready for Committer'
>
> Patches without documentation are never ready for commit. For this one, I'm
> not sure if that should be in the form of a reference example in contrib, or
> just something that documents that the hook exists and what the ground rules
> are for grabbing it.
Hooks are frequently not documented, and we only sometimes even bother
to include an example in contrib. We should probably at least have a
working example for testing purposes, though, whether or not we end up
committing it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-01-20 15:03:53 | Re: Command Triggers |
| Previous Message | Robert Haas | 2012-01-20 14:59:41 | Re: our buffer replacement strategy is kind of lame |