Skip site navigation (1) Skip section navigation (2)

Re: [v9.2] Fix Leaky View Problem

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Kohei(dot)Kaigai(at)emea(dot)nec(dot)com, thom(at)linux(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] Fix Leaky View Problem
Date: 2012-01-18 03:08:35
Message-ID: CA+TgmoZf_hqNPfAFZj6p=x=nN8zC0nMQCuey6+m_8x110c9Zsg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sun, Jan 8, 2012 at 10:32 AM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>>> I guess you concerned about that expected/select_views_1.out is
>>> patched, not expected/select_views.out.
>>> I'm not sure the reason why regression test script tries to make diff
>>> between results/select_views and expected/select_views_1.out.
>>
>> select_views.out and select_views_1.out are alternate expected output
>> files.  The regression tests pass if the actual output matches either
>> one.  Thus, you have to patch both.
>>
> It was new for me. The attached patch updates both of the expected
> files, however, I'm not certain whether select_view.out is suitable, or
> not, because my results/select_view.out matched with expected/select_view_1.out.

Committed.  We'll see what the buildfarm thinks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-01-18 03:28:45
Subject: Re: [v9.2] LEAKPROOF attribute of FUNCTION (Re: [v9.2] Fix Leaky View Problem)
Previous:From: Robert HaasDate: 2012-01-18 02:53:02
Subject: Re: [v9.2] sepgsql's DROP Permission checks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group