Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix install program detection

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix install program detection
Date: 2012-06-28 16:39:38
Message-ID: CA+TgmoZYhKWEfSYr9w1zww3yGLiKO5f9YgbFR0ghSMF3ijKVyQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, Jun 28, 2012 at 12:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Peter Eisentraut's message of mié jun 27 14:23:11 -0400 2012:
>>> Fix install program detection
>
>> Member grebe is still failing.
>
> protosciurus and castoroides (Solaris 10, I think same machine with
> different compilers) are not happy either.  Also, the first failure
> on those looks like:
>
> gmake[4]: Leaving directory `/export/home/dpage/pgbuildfarm/castoroides/HEAD/pgsql.17031/src/backend'
> /bin/sh ../../config/install-sh -c -d '/export/home/dpage/pgbuildfarm/castoroides/HEAD/pgsql.17031/src/test/regress/./tmp_check/install/export/home/dpage/pgbuildfarm/castoroides/HEAD/inst/lib'
> m 644  libpgport.a '/export/home/dpage/pgbuildfarm/castoroides/HEAD/pgsql.17031/src/test/regress/./tmp_check/install/export/home/dpage/pgbuildfarm/castoroides/HEAD/inst/lib/libpgport.a'
> gmake[3]: m: Command not found
> gmake[3]: [install] Error 127 (ignored)
>
> which seems bad for another reason: why are we ignoring a command error there?

I'm thinking that $INSTALL or whatever-it-is is getting set to an
empty string.  The command was probably intended to be something like
install -m 644 libpgport.a...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-committers by date

Next:From: Robert HaasDate: 2012-06-28 16:59:01
Subject: pgsql: Fix broken mmap failure-detection code,and improve error messag
Previous:From: Tom LaneDate: 2012-06-28 16:28:37
Subject: Re: pgsql: Fix install program detection

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group