Re: BUG #6083: psql script line numbers incorrectly count \copy data

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Steve Haslam <araqnid(at)googlemail(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: BUG #6083: psql script line numbers incorrectly count \copy data
Date: 2011-07-05 13:07:47
Message-ID: CA+TgmoZGZ_tP0gU6G8Ke8WB-aJJzstuHQJ3nFL5oAm4x4s3ODQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Jul 4, 2011 at 12:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Steve Haslam" <araqnid(at)googlemail(dot)com> writes:
>> ... Apparently, the data read from \copy
>> is incrementing the script line number counter?
>
> Yeah, so it is.  That is correct behavior for COPY FROM STDIN,
> but not so much for copying from a separate file.
>
> The attached patch seems like an appropriate fix.  However, I'm unsure
> whether to apply it to released branches ... does anyone think this
> might break somebody's application?

I think this is pretty safe.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Pavel Golub 2011-07-05 14:52:06 COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"
Previous Message Craig Ringer 2011-07-05 09:59:29 Re: BUG #6090: Connection problem

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-07-05 13:24:31 Re: Crash dumps
Previous Message Magnus Hagander 2011-07-05 13:05:14 Re: Crash dumps