Skip site navigation (1) Skip section navigation (2)

Re: control character check in JSON type seems broken

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: control character check in JSON type seems broken
Date: 2012-06-08 17:29:41
Message-ID: CA+TgmoZ04NoeezFHC-KW40bu6h5qkqe_zqPpirV2Ty+XSGpe_g@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugs
On Mon, Jun 4, 2012 at 8:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In addition, error message above seems corrupted in my environment.
>> Here we check not-escaped control character, so printing it with %c
>> formatting might break log files.  How about using decimal or hex dump
>> in such cases?
>
> And so is that.  IMO the error reporting in this module could stand to
> be reviewed altogether for compliance with our message guidelines.
> (For starters, why is it using errdetail_internal?)  I refrained from
> editorializing on-the-fly, but I'm not too pleased with what I saw.

Huh.  I have no idea why I thought errdetail_internal was a good idea.
 Should we just change all those to errdetail?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-bugs by date

Next:From: Robert HaasDate: 2012-06-08 17:37:53
Subject: Re: error connecting to postgresql by pgadmin
Previous:From: Simon RiggsDate: 2012-06-08 16:39:27
Subject: Re: BUG #6661: out-of-order XID insertion in KnownAssignedXids

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group