Skip site navigation (1) Skip section navigation (2)

Re: clog double-dip in heap_hot_search_buffer

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: clog double-dip in heap_hot_search_buffer
Date: 2012-05-02 16:07:55
Message-ID: CA+TgmoYt0WYGxdjJYUVdw8jFfnBPmzV5Q2tzTjd3-RJhbnGvCQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>
> s/alive/dead/ in that comment?

Yep, good catch, thanks.

> Otherwise this seems like a good idea.

Do you think I should apply this to 9.2, or wait until 9.3?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2012-05-02 16:15:38
Subject: Re: Temporary tables under hot standby
Previous:From: Tom LaneDate: 2012-05-02 16:06:43
Subject: Re: clog double-dip in heap_hot_search_buffer

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group