Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Jim Nasby <jim(at)nasby(dot)net>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Date: 2011-07-18 00:50:32
Message-ID: CA+TgmoYNghdhojsjpvQMVke=R+m948-dBKKdoZAjTv+LPV8ZyQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Jul 17, 2011 at 8:44 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> My understanding of git notes is that they can be added after a commit
> without changing the commit - indeed that's apparently a large part of their
> raison d'être:
>
>   A typical use of notes is to supplement a commit message without
>   changing the commit itself. Notes can be shown by git log along with
>   the original commit message.

Right... but it's still append-only, and I think that there is little
reason to suppose that append-only is what we want or need here.

> It is a pity that you can't define extra fields as is suggested above.

Agreed.  The 'git way' is apparently to add things like:

Reviewed-by: So And So <so(at)so(dot)com>

at the end of the commit message.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-07-18 01:20:38
Subject: Re: Single pass vacuum - take 1
Previous:From: Robert HaasDate: 2011-07-18 00:48:36
Subject: Re: Reduced power consumption in WAL Writer process

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-07-18 01:46:10
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Previous:From: Andrew DunstanDate: 2011-07-18 00:44:53
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group