Skip site navigation (1) Skip section navigation (2)

Re: Inconsistency in libpq connection parameters, and extension thereof

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Daniel Farina <daniel(at)heroku(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Shulgin <ash(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistency in libpq connection parameters, and extension thereof
Date: 2012-06-08 11:48:54
Message-ID: CA+TgmoYKsDEGOMGTb7dzqnq3DaU6Mk5oi3GON2zmdqZV-s=C-A@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Jun 6, 2012 at 6:04 PM, Daniel Farina <daniel(at)heroku(dot)com> wrote:
> On Wed, Jun 6, 2012 at 1:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Wed, Jun 6, 2012 at 4:08 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> However, not throwing errors on the URL syntax should be considered a
>>> bug, I think.
>>
>> +1.
>
> +1
>
> Here's a patch that just makes the thing an error.  Of course we could
> revert it if it makes the URI feature otherwise unusable...but I don't
> see a huge and terrible blocker ATM.  A major question mark for me any
> extra stuff in JDBC URLs.

It looks like the answer is "yes".

http://jdbc.postgresql.org/documentation/head/connect.html#connection-parameters

...but I'm inclined to think we should make this change anyway.  If
JDBC used libpq, then it might be nice to let JDBC parse out bits of
the URL and then pass the whole thing, unmodified, through to libpq,
without having libpq spit up.  But it doesn't.  And even if someone
were inclined to try to do something of that type, the warnings we're
omitting now would presumably discourage them.

Thoughts?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2012-06-08 11:53:56
Subject: Re: Inconsistency in libpq connection parameters, and extension thereof
Previous:From: Simon RiggsDate: 2012-06-08 09:28:12
Subject: Re: Skip checkpoint on promoting from streaming replication

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group