Skip site navigation (1) Skip section navigation (2)

Re: psql \ir filename normalization

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Josh Kupershmidt <schmiddy(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Subject: Re: psql \ir filename normalization
Date: 2011-11-21 19:50:48
Message-ID: CA+TgmoYAxBnKQTp2BYtk8Z+DTTSSVmHSnq4bMu6u8TG=L12RrA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Nov 21, 2011 at 2:30 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> On Mon, Nov 21, 2011 at 1:05 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > Robert Haas wrote:
>> >> Argh. ?The root of the problem here seems to be that
>> >> join_path_components() feels entitled to arbitrarily insert a pathname
>> >> separator at the front of the output string even if its first input
>> >> didn't begin with one originally. ?Lame!
>> >
>> > The attached patch fixes this report, I think.
>>
>> Looks sensible.  Keep in mind we need to back-patch this.
>
> Oh.  Well, with no bug reports about it, does that make sense?  Do we
> have any code that relies on the old behavior?

Oh, wait a minute.  I was thinking \ir was in 9.1, but it's not: it
was committed after the branch.  So I guess this only needs to be
fixed in master, which is much less scary.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2011-11-21 19:51:56
Subject: Re: psql \ir filename normalization
Previous:From: Bruce MomjianDate: 2011-11-21 19:30:37
Subject: Re: psql \ir filename normalization

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group