| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Thom Brown <thom(at)linux(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incorrect domain logic for 9.1 |
| Date: | 2012-04-24 15:53:25 |
| Message-ID: | CA+OCxozwPgX0zyDs2oVFWMq_MRuWpcGUHp8oL5Jg37tJsvTz=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Apr 23, 2012 at 9:36 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Mon, 2012-04-23 at 09:14 +0100, Dave Page wrote:
>> Hi
>>
>> I know Guillaume is working on domain support at the moment, so I'm
>> going to leave it to him to incorporate this change, if he hasn't
>> already fixed it.
>>
>
> I haven't fix it. I didn't even try to create a domain on a array.
>
>> Guillaume; let me know if you want me to treat it independently and
>> review/commit regardless.
>>
>
> Yes, please. If you can take care of it, it would be great.
Done - thanks Thom.
> I still need to fix an issue with the domain patch. If you have any idea
> about this contextual menu issue, that would be great.
They're always a pain in the backside to resolve. The usual issue is
that you've derived the action class from the wrong factory - usually
it needs to be contextActionFactory iirc.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2012-04-25 07:27:12 | Re: Incorrect domain logic for 9.1 |
| Previous Message | Dave Page | 2012-04-24 15:51:14 | pgAdmin III commit: Fix domains over array types [Thom Brown]. |