Skip site navigation (1) Skip section navigation (2)

Re: PATCH: EXTENSION keyword not supported by pgAdmin3

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: EXTENSION keyword not supported by pgAdmin3
Date: 2011-12-02 16:10:14
Message-ID: CA+OCxozt2eFhYDx8ZuXoTW9TOKA+eKSTDyiOieme2joagn6-MQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Thanks - applied!

On Fri, Dec 2, 2011 at 4:36 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:

> Please find the updated patch.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>
>
>
> On Thu, Dec 1, 2011 at 7:02 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> I did send it to you, a couple of emails ago.
>>
>>
>> On Thu, Dec 1, 2011 at 1:30 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Can you please share you dump file?
>>> I would like to experiment with it...
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>
>>>
>>>
>>> On Thu, Dec 1, 2011 at 6:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> The contents of the extensions are in public, but the comments are part
>>>> of the extension itself (ie. the "package"), so don't they also live
>>>> outside of any schema like the extension itself?
>>>>
>>>>
>>>> On Thu, Dec 1, 2011 at 1:23 PM, Ashesh Vashi <
>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Aren't they installed in that schema?
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>>>
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Dec 1, 2011 at 6:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Dec 1, 2011 at 12:57 PM, Ashesh Vashi <
>>>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>>  On Thu, Dec 1, 2011 at 4:43 PM, Dave Page <dpage(at)pgadmin(dot)org>wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On Wed, Nov 30, 2011 at 8:31 PM, Ashesh Vashi
>>>>>>>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>>> > Hi Dave,
>>>>>>>> >
>>>>>>>> > Please find the patch for the supporting the EXTENSION keyword in
>>>>>>>> the
>>>>>>>> > frmRestore dialog.
>>>>>>>> >
>>>>>>>> > Description:
>>>>>>>> > ============
>>>>>>>> > If User perform back up database with supported format like
>>>>>>>> custom and tar,
>>>>>>>> > it taken successfully. While browse the particular file on
>>>>>>>> Restore database
>>>>>>>> > and Click on display object, an error occurred while schema node
>>>>>>>> is not
>>>>>>>> > found.
>>>>>>>>
>>>>>>>> Something's not quite right - it's showing my table under an
>>>>>>>> extension node!
>>>>>>>>
>>>>>>>
>>>>>>> Yeah - that was a typical "Copy/Paste" error.
>>>>>>> PFA - the updated patch.
>>>>>>>
>>>>>>>
>>>>>> Slightly better. Now the extension comments are shown under the
>>>>>> public schema.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2011-12-02 18:30:59
Subject: Re: PATCH: EXTENSION keyword not supported by pgAdmin3
Previous:From: Dave PageDate: 2011-12-02 16:10:01
Subject: pgAdmin III commit: Fix handling of EXTENSIONs in the restoredialogue.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group