Skip site navigation (1) Skip section navigation (2)

Re: Prevent duplicate attributes

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Prevent duplicate attributes
Date: 2011-07-12 09:53:19
Message-ID: CA+OCxozVEFrgkNU8iXw_tzm_L3nCYjd+jjU9XQd4JwPa_raboA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> Hi (yes, me... again),
>
> Tiny patch attached to prevent adding attributes with a duplicate name
> to a type.  It seems previous versions prevented this, but must have
> been allowed in a commit since the last release.

For consistency with the other checks on the dialogue, this should
cause the "Add" button to be disabled, not make it silently fail. That
should almost certainly be done in dlgType::CheckChange().


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Thom BrownDate: 2011-07-12 09:55:25
Subject: Re: Prevent duplicate attributes
Previous:From: Thom BrownDate: 2011-07-11 14:29:51
Subject: Re: Overhaul of type attributes modification

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group