Re: Two strange settings in frmOptions

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Two strange settings in frmOptions
Date: 2011-12-12 14:08:50
Message-ID: CA+OCxoyh2dBD1J4kGqsXs=Y0YS+PmEZeFEy4_LqmbndE0zr1aA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Dec 12, 2011 at 7:27 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Noticed two things in Options->QueryTool:
>
> 1) There is a settin gfor "Maximum rows to retreive". From what I can
> tell, this is *only* used for pgagent (pgaJobs.cpp and pgaStep.cpp).
> If that is so, it shuld not be under Query Tool settings. Potentially
> it could be removed completely, if pgAgent can actually deal with a
> hardcode there?

It's not that pgAgent can or can't cope - it's just there to put a
limit on the number of rows we try to load into the Statistics tab on
the main form. Agreed, it shouldn't be under Query Tool.

> 2) There is a setting for "Count rows if estimated less than". AFAICT,
> this again has nothing to do with the query tool - this is for the
> object browser, when you click a table. Shouldn't it be moved to be
> under another tab?

+1

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-12-12 14:12:24 pgagent extension
Previous Message Magnus Hagander 2011-12-12 13:57:43 Two strange settings in frmOptions