| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixed FB 20417 |
| Date: | 2012-01-10 09:39:45 |
| Message-ID: | CA+OCxoxy7rg6oRPsUZUCTuWWzF=7nsZ60yqt2c+_gwPfzg0sCw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote:
>> Hi Dave
>>
>> Modified the logic. Attached is the patch file, please review it.
>>
>
> This is still wrong. bIsChangeComment isn't always true when the user
> creates a replication cluster. It's only true if there is a comment.
Seems a little long-winded too - can't you just replace the current
IsEmpty() test with something like "if (txtComment->GetValue() !=
cluster->GetComment())"?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2012-01-10 10:09:42 | Re: Fixed FB 20417 |
| Previous Message | Guillaume Lelarge | 2012-01-10 09:36:39 | Re: Fixed FB 20417 |