Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>
Subject: Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
Date: 2012-04-11 10:20:06
Message-ID: CA+OCxoxYLaewU6MVD04zeBjggERMyYCBNZE=RaLPmM4Y=au+Qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Sachin, could you review this please? I'm swamped right now.

Thanks.

On Mon, Apr 9, 2012 at 7:15 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:

> Hi Dave,
>
> During resolving a bug - "Error message is displayed when the packages is
> clicked", I found that:
> - We are not properly handling the default parameters for the functions &
> procedures properly, when the function is type of 'edbspl'.
> - We also do not handle the default parameters for the functions &
> procedures properly under the packages.
>
> In 'edbspl', we do not allow the default parameters with INOUT parameters
> and that reflects in the reverse-engineering for those functions &
> procedures.
>
> Attached patches resolve the above issues for REL-1_14 and master branches.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2012-04-11 10:48:53 pgAdmin III commit: Ensure we track the dialogue in the correct object
Previous Message Dave Page 2012-04-11 08:11:40 Re: Weird code in pgDomain.cpp