Skip site navigation (1) Skip section navigation (2)

Re: v1.14 SQL editor collapsing feature

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Ken Haley <khaley4(at)gmail(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: v1.14 SQL editor collapsing feature
Date: 2011-11-13 18:44:23
Message-ID: CA+OCxoxVu7p3XUWNub_vV6yGOq+S14+aZ9CUEdL+XMC0=Mm5Tg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, Nov 13, 2011 at 9:02 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Mon, 2011-11-07 at 09:26 -0600, Ken Haley wrote:
>> I think there is a point: (a) the block folding option (as I think it's
>> called elsewhere) is buggy -- it doesn't seem to handle nested if's
>> correctly, sometimes mis-matches parentheses, etc.  (b) Several times, I've
>> accidentally collapsed a block trying to highlight an entire line (using
>> the far left margin).  It's annoying to have to open the block back up and
>> find the line again. This needs to be an optional feature, I think.
>
> Well, if it's buggy, it should be fixed. There's probably not much we
> can do here as it is part of wxWidgets but at least, we can move the
> information upstream. So, if you have any *detailed* information of that
> kind, please, give it.
>
> I agree on the second part.
>
> I have nothing against adding an option on that feature. That would be
> fairly easy to do. Dave, do you feel strongly against adding the option?
> or is it simply not worth your time? (which would be quite
> understandable)

If there are demonstrable issues with wxSTC that can cause annoyance
and loss of productivity that we can't easily get fixed, then I don't
object to having an option to switch it off.

I'm not sure how one could accidentally toggle a block regularly
though; it's not something I recall ever doing - and to do it often
enough *and* reproduce a bug that to my knowledge hasn't been reported
before seems like it would be hard to cause more than trivial
annoyance; unless there's something specific to Ken's environment at
play here as well.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-11-13 22:06:00
Subject: Re: [PATCH] Improve autocompletion for SELECT statements
Previous:From: Guillaume LelargeDate: 2011-11-13 17:35:03
Subject: Re: Compilation on Debian SID

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group