Skip site navigation (1) Skip section navigation (2)

Re: Incorrect domain logic for 9.1

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: Incorrect domain logic for 9.1
Date: 2012-04-23 08:14:15
Message-ID: CA+OCxowgc9zjUrgHuNztBEFdRqBt6=-JBiYHyXW-Qw545ei79g@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi

I know Guillaume is working on domain support at the moment, so I'm
going to leave it to him to incorporate this change, if he hasn't
already fixed it.

Guillaume; let me know if you want me to treat it independently and
review/commit regardless.

Thanks.

On Sat, Apr 21, 2012 at 10:21 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> Hi,
>
> I noticed that if I create a domain based on an array data type, it
> doesn't get listed in the Domains node if the server is 9.1.  This is
> because the query that gets the domains says that if the number of
> dimensions used is greater than 0 (which it will be if it's an array),
> then it must match against the OID shown in typelem.  As of 9.1 that's
> no longer the case as typelem isn't used for domains anymore, although
> I don't see why this was ever used by PgAdmin to get a list of domains
> as it copes fine without this logic since typbasetype always provides
> the necessary info.  Is the constituent base type of the array type
> relevant anywhere in the domains section of PgAdmin?  I can't find any
> place it actually uses it.
>
> The attached patch removes the join logic completely to make it a
> straightforward join.  From what I can tell (testing it against 8.4),
> everything continues to work as usual, and now allows array-based
> domains to be visible for 9.1 instances.
>
> Could someone take a look, and see if there are cases this might
> break?  In any case, a fix is needed.
>
> --
> Thom
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2012-04-23 20:24:54
Subject: [pgAdmin III] #362: pgScript and ampersand
Previous:From: Dave PageDate: 2012-04-23 08:12:37
Subject: Re: Remaining work for 1.16

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group