Skip site navigation (1) Skip section navigation (2)

Re: Refresh objects on Click

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Refresh objects on Click
Date: 2011-08-11 10:25:39
Message-ID: CA+OCxowXyeVOz+8n5Nm7L8fwZ5-qOBtbncn6Ub_nXSm0S_ZPDg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, Aug 11, 2011 at 4:20 AM, Vinicius Santos
<vinicius(dot)santos(dot)lista(at)gmail(dot)com> wrote:
> Em 10/08/2011 07:34, Dave Page escreveu:
>>
>> Please see about fixing those issues, and then I can give it a more in
>> depth review.
>
> I fixed the items in question, and performed some more tests.
>
> Apparently it's OK.
>
> If any bugs or any suggestions, please let me know.

Looking better :-)

- On frmOptions, the combo box to select the refresh mode should be to
the right of the label, not underneath. The sizing should following
the layout of other tabs.

- In "Refresh object on click" mode, if I click a table, and then
click the parent database, all nodes below the "Schemas" node are
collapsed.

- Please use an actual declared enum for the setting, so we can avoid
using "magic" numbers in execSelChange() - eg. if
(settingRefreshOnClick == REFRESH_OBJECT_ONLY)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-08-11 11:36:45
Subject: pgAgent commit: Add missing includes, needed on Solaris.
Previous:From: Dave PageDate: 2011-08-11 07:52:21
Subject: Re: Fixing issues between objects and properties dialogs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group